Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade slice to 0.38 #14014

Merged
merged 1 commit into from
Jan 27, 2020
Merged

Upgrade slice to 0.38 #14014

merged 1 commit into from
Jan 27, 2020

Conversation

jagill
Copy link
Contributor

@jagill jagill commented Jan 24, 2020

Previous version was 0.36. There was one minor incompatibility.

== RELEASE NOTES ==

General Changes
* Upgrade airlift/slice to 0.38.

Previous version was 0.36.  There was one minor incompatibility.
@wenleix
Copy link
Contributor

wenleix commented Jan 24, 2020

@jagill : Any plan to use https://github.com/prestodb/slice ? ;)

@jagill
Copy link
Contributor Author

jagill commented Jan 26, 2020

@wenleix This is a very small PR that does not change any philosophical orientation. prestodb/slice can be a follow-up commit, which will take advantage of the fact that this commit solves one backwards-incompatibility :)

@wenleix
Copy link
Contributor

wenleix commented Jan 27, 2020

@jagill : Sounds reasonable. Just keep in mind you might have to backport some changes to prestodb/slice if we start to rely on features in newer version in airlift/slice :)

Copy link
Contributor

@wenleix wenleix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wenleix wenleix merged commit b1cda97 into prestodb:master Jan 27, 2020
@wenleix
Copy link
Contributor

wenleix commented Jan 27, 2020

Merged #14014, thanks for the contribution!

@jagill jagill deleted the upgrade-slice branch January 28, 2020 05:13
@caithagoras caithagoras mentioned this pull request Feb 20, 2020
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants